This talk was given at DjangoCon 2018 in San Diego, CA. Find the slides, video, and feedback in this post.
View the slides on SpeakerDeck
As teams and projects grow, code review becomes increasingly important to support the maintainability of complex codebases. In this talk, I’ll cover guidelines for writing consistent python code beyond pep8, how to look out for common python gotchas, and what python tools are available to automate various parts of the review process. Most importantly, I’ll cover the human aspect of code reviews - how we can be better at approaching reviews with empathy and understanding from the perspective of both a reviewer and a submitter. Following these successful code review practices will lead to happier teams and healthier code bases.
This talk is useful for python developers with any amount of experience. No prerequisite knowledge is necessary.
- For those who are just starting out, it will be a great general overview.
- Intermediate developers may not know about the wide variety of tooling that’s available.
- Advanced developers will learn techniques for performing code reviews with empathy.
This talk will enable you to have better code reviews on your teams at work, and a better approach to code reviews in open source projects. You’ll leave with 3 main takeaways:
- Code Reviews are most effective when conducted with empathy. If you do reviews with growth and learning in mind, they become tools for sharing knowledge instead of an opportunity to bruise egos or show off esoteric knowledge.
- Python has powerful tooling available for code reviews such as pep8 as a style guide, pylint as a linter, coverage.py to identify test coverage, and vulture to identify dead code.
- That python style guides beyond pep8 have clear benefits in terms of producing more consistent code that’s easier to review and easier to maintain.
"Code Reviews are most effective when conducted with empathy. If you do reviews with growth and learning in mind, they become tools for sharing knowledge instead of an opportunity to bruise egos or show off esoteric knowledge." - @nnja #DjangoCon #Perspective— Sanchit Balchandani (@inovizz) October 16, 2018
💙 this photo from the @djangocon women's & non-binary lunch, hosted by @pyladies @djangogirls and @azureadvocates. Had a great time talking to @laceynwilliams @hayleydenb @mariatta & so many other incredible and inspiring folks. pic.twitter.com/KKo9UMjY1o— 𝙽𝚒𝚗𝚊 𝚉𝚊𝚔𝚑𝚊𝚛𝚎𝚗𝚔𝚘 💜🐍 (@nnja) October 17, 2018